Update vulnerabilities infobar text to invoke Copilot#7206
Update vulnerabilities infobar text to invoke Copilot#7206
Conversation
|
@martinrrm can you add a screenshot of what this looks like? |
| <data name="InfoBar_HyperlinkFixVulnerabilitiesWithCopilot" xml:space="preserve"> | ||
| <value>Fix with GitHub Copilot</value> | ||
| <comment>Do not translate GitHub or Copilot</comment> | ||
| <value>Fix</value> |
There was a problem hiding this comment.
The request asks for updated wording and for a sparkle icon to appear next to “Fix.” I only see .resx changes in this PR, so it appears to update the wording only and does not introduce the icon next to or as part of the hyperlink. Is that correct?
There was a problem hiding this comment.
The infobar doesn't accept monikers inside the text, I wasn't able to get the suggested sparkle icon just this using /u2726, what do you suggest we should do?
There was a problem hiding this comment.
We talked offline. What we discussed:
- The first step is to investigate if the InfoBar can support an image or custom XAML.
- If not, file an issue against the InfoBar APIs and link it as a blocker for this issue.
The wording should be updated only when the sparkle icon can be added to the hyperlink.
dotnet-policy-service
bot
added
the
Status:No recent activity
|
Seems important to clearly indicate when GitHub Copilot will be used. Not sure why the sparkle icon is important enough to delay this PR, design language can't trump transparency in this case right? |
dotnet-policy-service
bot
removed
the
Status:No recent activity
3 participants
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3587
Description
Update infobar to the recommended text
PR Checklist
[ ] Added tests